Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version in nvmrc #21430

Merged
merged 1 commit into from
May 5, 2021
Merged

Conversation

MoonBall
Copy link
Contributor

@MoonBall MoonBall commented May 5, 2021

Summary

When I execute yarn, I get an error.

AssertionError [ERR_ASSERTION]: Current node version is not supported for development, expected "12.16.2" to satisfy "^12.17.0 || 13.x || 14.x || 15.x || 16.x".

The devEngines field in package.json file is:

react/package.json

Lines 102 to 104 in e9a4a44

"devEngines": {
"node": "^12.17.0 || 13.x || 14.x || 15.x || 16.x"
},

But the node version in .nvmrc file is:

react/.nvmrc

Line 1 in e9a4a44

v12.16.2

Test Plan

No.

@sizebot
Copy link

sizebot commented May 5, 2021

Comparing: e9a4a44...e80bb08

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.76 kB 122.76 kB = 39.42 kB 39.42 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.29 kB 129.29 kB = 41.50 kB 41.50 kB
facebook-www/ReactDOM-prod.classic.js = 407.18 kB 407.18 kB = 75.34 kB 75.34 kB
facebook-www/ReactDOM-prod.modern.js = 395.01 kB 395.01 kB = 73.41 kB 73.41 kB
facebook-www/ReactDOMForked-prod.classic.js = 407.18 kB 407.18 kB = 75.34 kB 75.34 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against e80bb08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants