Support @latest in prepare-release-from-ci
#21616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 8f37942...2f88956 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
bvaughn
approved these changes
Jun 3, 2021
| @@ -23,7 +23,8 @@ const run = async () => { | |||
| await testPackagingFixture(params); | |||
| } | |||
|
|
|||
| await printPrereleaseSummary(params, false); | |||
| const isLatestRelease = params.releaseChannel === 'latest'; | |||
| await printPrereleaseSummary(params, isLatestRelease); | |||
There was a problem hiding this comment.
Why do we pin differently for the latest release?
There was a problem hiding this comment.
What's "pin" mean in this context?
There was a problem hiding this comment.
D'oh, nevermind sorry. I misread this.
Since we track these versions in source, we can build `@latest` releases in CI and store them as artifacts. Then when it's time to release, and the build has been verified, we use `prepare-release-from-ci` (the same script we use for `@next` and `@experimental`) to fetch the already built and versioned packages.
acdlite
force-pushed
the
support-latest-in-prepare-from-ci-script
branch
from
0de4150
to
2f88956
Compare
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
Since we track these versions in source, we can build `@latest` releases in CI and store them as artifacts. Then when it's time to release, and the build has been verified, we use `prepare-release-from-ci` (the same script we use for `@next` and `@experimental`) to fetch the already built and versioned packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we track these versions in source, we can build
@latestreleases in CI and store them as artifacts.Then when it's time to release, and the build has been verified, we use
prepare-release-from-ci(the same script we use for@nextand@experimental) to fetch the already built and versioned packages.