Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for Suspense layout semantics #21677

Closed
wants to merge 1 commit into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jun 14, 2021

Failing test for #21676.

For some reason I couldn't repro it with noop renderer, which is used for all related tests like here.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 14, 2021
@gaearon gaearon requested a review from bvaughn June 14, 2021 15:21
@sizebot
Copy link

sizebot commented Jun 14, 2021

Comparing: 1a106bd...ce8d95b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 126.89 kB 126.89 kB = 40.69 kB 40.69 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.70 kB 129.70 kB = 41.61 kB 41.61 kB
facebook-www/ReactDOM-prod.classic.js = 406.00 kB 406.00 kB = 75.07 kB 75.07 kB
facebook-www/ReactDOM-prod.modern.js = 394.35 kB 394.35 kB = 73.25 kB 73.25 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.00 kB 406.00 kB = 75.07 kB 75.07 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against ce8d95b

@gaearon
Copy link
Collaborator Author

gaearon commented Jun 14, 2021

What I'm seeing debugging this is that after Suspense is re-shown, "c" does not get logged:

Screenshot 2021-06-14 at 16 32 11

So this tells me that we don't apply LayoutMask to subtreeFlags for some reason though we should have. (maybe?)

@bvaughn
Copy link
Contributor

bvaughn commented Jun 16, 2021

Fix in #21694

@bvaughn bvaughn closed this Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants