Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fizz/Flight] Don't use default args #21681

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Conversation

sebmarkbage
Copy link
Collaborator

These don't compile very nicely because they end up checking the argument length instead of undefinedness for some reason.

@sebmarkbage sebmarkbage requested a review from gaearon June 14, 2021 21:48
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 14, 2021
@sizebot
Copy link

sizebot commented Jun 14, 2021

Comparing: bd45ad0...77f4e2e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.08 kB 127.08 kB = 40.74 kB 40.74 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.89 kB 129.89 kB = 41.67 kB 41.67 kB
facebook-www/ReactDOM-prod.classic.js = 405.00 kB 405.00 kB = 74.92 kB 74.92 kB
facebook-www/ReactDOM-prod.modern.js = 393.35 kB 393.35 kB = 73.10 kB 73.10 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.00 kB 405.00 kB = 74.92 kB 74.92 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactFlightDOMRelayServer-dev.classic.js = 27.60 kB 27.54 kB = 7.19 kB 7.16 kB
facebook-www/ReactFlightDOMRelayServer-dev.modern.js = 27.60 kB 27.54 kB = 7.19 kB 7.16 kB
facebook-relay/flight/ReactFlightNativeRelayServer-dev.js = 27.34 kB 27.28 kB = 7.25 kB 7.23 kB
facebook-relay/flight/ReactFlightNativeRelayServer-prod.js = 15.95 kB 15.88 kB = 4.05 kB 4.03 kB
facebook-www/ReactFlightDOMRelayServer-prod.classic.js = 15.54 kB 15.47 kB = 3.95 kB 3.94 kB
facebook-www/ReactFlightDOMRelayServer-prod.modern.js = 15.54 kB 15.47 kB = 3.95 kB 3.94 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.min.js = 32.85 kB 32.67 kB = 10.88 kB 10.84 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.production.min.js = 32.71 kB 32.54 kB = 10.83 kB 10.79 kB
oss-stable/react-dom/cjs/react-dom-server.node.production.min.js = 32.71 kB 32.54 kB = 10.83 kB 10.79 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.min.js = 32.25 kB 32.08 kB = 10.66 kB 10.62 kB
oss-experimental/react-dom/umd/react-dom-server.browser.production.min.js = 32.43 kB 32.26 kB = 10.80 kB 10.76 kB
oss-stable-semver/react-dom/umd/react-dom-unstable-fizz.browser.production.min.js = 32.41 kB 32.21 kB = 11.00 kB 10.94 kB
oss-stable/react-dom/umd/react-dom-unstable-fizz.browser.production.min.js = 32.41 kB 32.21 kB = 11.00 kB 10.94 kB
oss-experimental/react-dom/umd/react-dom-unstable-fizz.browser.production.min.js = 32.54 kB 32.33 kB = 11.05 kB 10.99 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.browser.production.min.js = 32.37 kB 32.17 kB = 10.93 kB 10.88 kB
oss-stable-semver/react-dom/cjs/react-dom-unstable-fizz.browser.production.min.js = 32.25 kB 32.04 kB = 10.88 kB 10.84 kB
oss-stable/react-dom/cjs/react-dom-unstable-fizz.browser.production.min.js = 32.25 kB 32.04 kB = 10.88 kB 10.84 kB
oss-experimental/react-dom/cjs/react-dom-unstable-fizz.node.production.min.js = 32.65 kB 32.45 kB = 10.93 kB 10.88 kB
oss-stable-semver/react-dom/cjs/react-dom-unstable-fizz.node.production.min.js = 32.53 kB 32.33 kB = 10.89 kB 10.84 kB
oss-stable/react-dom/cjs/react-dom-unstable-fizz.node.production.min.js = 32.53 kB 32.33 kB = 10.89 kB 10.84 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.production.min.server.js = 6.86 kB 6.82 kB = 2.90 kB 2.89 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.production.min.server.js = 6.86 kB 6.82 kB = 2.90 kB 2.89 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.production.min.server.js = 6.86 kB 6.82 kB = 2.90 kB 2.89 kB
oss-experimental/react-server/cjs/react-server-flight.production.min.js = 6.83 kB 6.79 kB = 2.86 kB 2.85 kB
oss-stable-semver/react-server/cjs/react-server-flight.production.min.js = 6.83 kB 6.79 kB = 2.86 kB 2.85 kB
oss-stable/react-server/cjs/react-server-flight.production.min.js = 6.83 kB 6.79 kB = 2.86 kB 2.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.production.min.server.js = 6.66 kB 6.61 kB = 2.79 kB 2.77 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.production.min.server.js = 6.66 kB 6.61 kB = 2.79 kB 2.77 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.production.min.server.js = 6.66 kB 6.61 kB = 2.79 kB 2.77 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.production.min.server.js = 6.65 kB 6.60 kB = 2.81 kB 2.80 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.production.min.server.js = 6.65 kB 6.60 kB = 2.81 kB 2.80 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.production.min.server.js = 6.65 kB 6.60 kB = 2.81 kB 2.80 kB
facebook-www/ReactDOMServer-prod.modern.js = 72.87 kB 72.24 kB = 14.98 kB 14.86 kB
oss-experimental/react-server/cjs/react-server.production.min.js = 17.64 kB 17.46 kB = 5.99 kB 5.95 kB
oss-stable-semver/react-server/cjs/react-server.production.min.js = 17.52 kB 17.34 kB = 5.95 kB 5.91 kB
oss-stable/react-server/cjs/react-server.production.min.js = 17.52 kB 17.34 kB = 5.95 kB 5.91 kB

Generated by 🚫 dangerJS against 77f4e2e

@sebmarkbage sebmarkbage merged commit 502f8a2 into facebook:master Jun 14, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
* Don't use default args

* Hoist out creation for better inlining

The closures prevent inlining otherwise.
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jun 22, 2021
Summary:
This sync includes the following changes:
- **[43f4cc160](facebook/react@43f4cc160 )**: Fix failing test ([#21697](facebook/react#21697)) //<Dan Abramov>//
- **[d0f348dc1](facebook/react@d0f348dc1 )**: Fix for failed Suspense layout semantics ([#21694](facebook/react#21694)) //<Brian Vaughn>//
- **[bd0a96344](facebook/react@bd0a96344 )**: Throw when `act` is used in production ([#21686](facebook/react#21686)) //<Andrew Clark>//
- **[9343f8720](facebook/react@9343f8720 )**: Use the server src files as entry points for the builds/tests ([#21683](facebook/react#21683)) //<Sebastian Markbåge>//
- **[502f8a2a0](facebook/react@502f8a2a0 )**: [Fizz/Flight] Don't use default args ([#21681](facebook/react#21681)) //<Sebastian Markbåge>//
- **[a8f5e77b9](facebook/react@a8f5e77b9 )**: Remove invokeGuardedCallback from commit phase ([#21666](facebook/react#21666)) //<Dan Abramov>//
- **[dbe3363cc](facebook/react@dbe3363cc )**: [Fizz] Implement Legacy renderToString and renderToNodeStream on top of Fizz ([#21276](facebook/react#21276)) //<Sebastian Markbåge>//
- **[101ea9f55](facebook/react@101ea9f55 )**: Set deletedTreeCleanUpLevel to 3 ([#21679](facebook/react#21679)) //<Dan Abramov>//
- **[1a106bdc2](facebook/react@1a106bdc2 )**: Wrap eventhandle-specific logic in a flag ([#21657](facebook/react#21657)) //<Dan Abramov>//
- **[cb30388d1](facebook/react@cb30388d1 )**: Export React Native `AttributeType` Types ([#21661](facebook/react#21661)) //<Timothy Yung>//
- **[c1536795c](facebook/react@c1536795c )**: Revert "Make enableSuspenseLayoutEffectSemantics static for www ([#21617](facebook/react#21617))" ([#21656](facebook/react#21656)) //<Sebastian Markbåge>//

Changelog:
[General][Changed] - React Native sync for revisions c96b78e...568dc35

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D29303157

fbshipit-source-id: 90952885eb2264f4effa04070357b80700bb9be3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants