Code

Scheduling profiler UX changes#21990

Code

Merged

bvaughn merged 21 commits intofacebook:mainfacebook/react:mainfrom bvaughn:devtools-scheduling-profilerbvaughn/react:devtools-scheduling-profilerCopy head branch name to clipboardAug 2, 2021

+2,005-1,255

Commits

Commits on Jul 30, 2021

• Refactored scheduling profiler colors and tooltip text/info

  

  Brian Vaughn

  committed
  5971eb7

  Copy full SHA for 5971eb7

• Removed a console log statement from hook names Suspense cache

  

  Brian Vaughn

  committed
  6dd1a62

  Copy full SHA for 6dd1a62

• Separate suspense events into their own rows, and display as ranges

  

  Brian Vaughn

  committed
  f587019

  Copy full SHA for f587019

• Refactored resizable view and made several views resizable

  Show description for 78be7e7
  

  Brian Vaughn

  committed
  78be7e7

  Copy full SHA for 78be7e7

• Hide snapshot selector if Scheduling Profiler is active

  

  Brian Vaughn

  committed
  0f70583

  Copy full SHA for 0f70583

• Improved ResizeView and ResizeBar UX

  Show description for f44c87f
  

  Brian Vaughn

  committed
  f44c87f

  Copy full SHA for f44c87f

• Show unresolved suspends as gray diamond marks

  

  Brian Vaughn

  committed
  0592a28

  Copy full SHA for 0592a28

• Scroll view shows up/down caret overlay indicating content is above or below the fold

  

  Brian Vaughn

  committed
  16088f2

  Copy full SHA for 16088f2

• Resize bars show labels now when collapsed

  

  Brian Vaughn

  committed
  216f4cd

  Copy full SHA for 216f4cd

• Changed scroll wheel behavior

  Show description for b7e66ec
  

  Brian Vaughn

  committed
  b7e66ec

  Copy full SHA for b7e66ec

• Clip Suspense diamonds so they don't overflow after being resized

  

  Brian Vaughn

  committed
  9c656f2

  Copy full SHA for 9c656f2

Commits on Jul 31, 2021

• Set default height for resizable views

  

  Brian Vaughn

  committed
  1f476f3

  Copy full SHA for 1f476f3

• Tweaked layout and passive colors to align more with commit phase color

  Show description for 1610784
  

  Brian Vaughn

  committed
  1610784

  Copy full SHA for 1610784

• Added Suspense event row-border lines

  

  Brian Vaughn

  committed
  1399595

  Copy full SHA for 1399595

• Updated profiler failing (snapshot) tests

  

  Brian Vaughn

  committed
  245d7c3

  Copy full SHA for 245d7c3

• Tweaked caret colors to be more visible

  

  Brian Vaughn

  committed
  a987428

  Copy full SHA for a987428

• Profiler now remembers which (sub) tab was previously selected

  

  Brian Vaughn

  committed
  772b2c3

  Copy full SHA for 772b2c3

Commits on Aug 1, 2021

• Updated cursor styles

  

  Brian Vaughn

  committed
  a28ef99

  Copy full SHA for a28ef99

• Don't show tooltips for flamegraph nodes that are too small to be visible

  

  Brian Vaughn

  committed
  586aefa

  Copy full SHA for 586aefa

Commits on Aug 2, 2021

• Prevent hidden views from triggering cursor/tooltip interactions

  

  Brian Vaughn

  committed
  17e3832

  Copy full SHA for 17e3832

• Fixed unrelated key warning in DevTools test shell

  

  Brian Vaughn

  committed
  89979f5

  Copy full SHA for 89979f5