Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduling profiler UX changes #22004

Closed
wants to merge 22 commits into from
Closed

Scheduling profiler UX changes #22004

wants to merge 22 commits into from

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Aug 2, 2021 •
edited
Loading

Builds on top of #21990

  • Add a vertical scrollbar to right side when sum of view heights is larger than the canvas.
  • Fix "nested update during layout" warning to only show if the update was long.

Brian Vaughn added 22 commits July 30, 2021 19:33
Refactored scheduling profiler colors and tooltip text/info
5971eb7
Removed a console log statement from hook names Suspense cache
6dd1a62
Separate suspense events into their own rows, and display as ranges
f587019
Refactored resizable view and made several views resizable
78be7e7 
Also refactored text logic into a drawText helper.
Hide snapshot selector if Scheduling Profiler is active
0f70583
Improved ResizeView and ResizeBar UX
f44c87f 
Double click on a resize view to toggle expand/collapse.

Resize bar has border and ellipsis like Chrome bar.
Show unresolved suspends as gray diamond marks
0592a28
Scroll view shows up/down caret overlay indicating content is above o…
16088f2 
…r below the fold
Resize bars show labels now when collapsed
216f4cd
Changed scroll wheel behavior
b7e66ec 
Vertical wheel now zooms. Horizontal wheel pans. (Vertical wheel with shift zooms.)

Wheel events of any kind clear the current tooltip as well.
Clip Suspense diamonds so they don't overflow after being resized
9c656f2
Set default height for resizable views
1f476f3
Tweaked layout and passive colors to align more with commit phase color
1610784 
They seemed to separate/bold before
Added Suspense event row-border lines
1399595
Updated profiler failing (snapshot) tests
245d7c3
Tweaked caret colors to be more visible
a987428
Profiler now remembers which (sub) tab was previously selected
772b2c3
Updated cursor styles
a28ef99
Don't show tooltips for flamegraph nodes that are too small to be vis…
586aefa 
…ible
Prevent hidden views from triggering cursor/tooltip interactions
17e3832
Fixed unrelated key warning in DevTools test shell
89979f5
STASHING
eaa8c2c
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 2, 2021
@bvaughn bvaughn closed this Aug 2, 2021
@bvaughn bvaughn deleted the devtools-scheduling-profiler-vertical-scroll branch August 2, 2021 13:27
@sizebot
Copy link

sizebot commented Aug 2, 2021

Comparing: b537247...eaa8c2c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.58 kB 127.58 kB = 40.72 kB 40.71 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.40 kB 130.40 kB = 41.64 kB 41.64 kB
facebook-www/ReactDOM-prod.classic.js = 406.43 kB 406.43 kB = 75.25 kB 75.24 kB
facebook-www/ReactDOM-prod.modern.js = 394.79 kB 394.79 kB = 73.52 kB 73.52 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.43 kB 406.43 kB = 75.25 kB 75.25 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against eaa8c2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bvaughn @sizebot @facebook-github-bot