Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduling Profiler: Misc UX and performance improvements #22043

Merged
merged 4 commits into from
Aug 9, 2021
Merged

Scheduling Profiler: Misc UX and performance improvements #22043

merged 4 commits into from
Aug 9, 2021

Commits on Aug 9, 2021

  1. Resize view should ignore clicks if scrollbar is hidden

    Brian Vaughn committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    7a8875c View commit details
    Browse the repository at this point in the history

  2. Optimized batch UID to measures and lane to measures computations 

    Previously this was done by looping through an array. Now it's done by building up a Map during processing.

Also moved the measures-to-lanes calculation out of the ReactMeasuresView and into preprocessData.
    Brian Vaughn committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    2028e7b View commit details
    Browse the repository at this point in the history

  3. Hide context menu(s) when zooming or panning

    Brian Vaughn committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    4cee86b View commit details
    Browse the repository at this point in the history

  4. Lifted view state into context so it persists between tabs 

    This almost works perfectly, except for a small problem restoring vertical scroll position. Will address in a follow up.
    Brian Vaughn committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    40342c1 View commit details
    Browse the repository at this point in the history