Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add named hooks support to react-devtools-inline #22263

Merged
merged 8 commits into from
Sep 9, 2021
Merged

Add named hooks support to react-devtools-inline #22263

merged 8 commits into from
Sep 9, 2021
+415 −278

Commits on Sep 9, 2021

  1. Added named hooks feature flag to DevToolsFeatureFlags

    Brian Vaughn committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    08c3fcb View commit details
    Browse the repository at this point in the history

  2. Added new dynamic import suspense cache 

    And used it to import named hooks code.

Note this commit currently breaks the test shell.
    Brian Vaughn committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    06fab2d View commit details
    Browse the repository at this point in the history

  3. Added hookNames entrypoint to react-devtools-inline 

    And changed dynamic import() code to be passed in rather than embedded in the package
    Brian Vaughn committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    b941b03 View commit details
    Browse the repository at this point in the history

  4. Removed named hooks prefetch step since we are using cached network r… 

    …esponses.
    Brian Vaughn committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    398dacd View commit details
    Browse the repository at this point in the history

  5. Added TODO to follow up on HookNamesModuleLoader param 

    Ideally we can remove this param once the Webpack 5 upgrade has finished.
    Brian Vaughn committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    f4c7df5 View commit details
    Browse the repository at this point in the history

  6. Fixed incorrect path in dynamic import()

    Brian Vaughn committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    22d2eb2 View commit details
    Browse the repository at this point in the history

  7. Added instructions to react-devtools-inline README for new import() f… 

    …actory function
    Brian Vaughn committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    7c8609d View commit details
    Browse the repository at this point in the history

  8. Replaced test shell Webpack 'cheap-module-eval-source-map' source-map… 

    … setting with 'cheap-source-map'

This fixes named hooks for the test shell and doesn't seem to slow things down noticeably either.
    Brian Vaughn committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    e89d47d View commit details
    Browse the repository at this point in the history