Revert Suspense cache Thenable.catch() change

[bvaughn]

Stacks on top of PR #22263 to avoid causing merge conflicts in hookNamesCache.js.

Compare the two branches only

Reverts part of #22275 (adding .catch() to Thenables in Suspense caches) in response to #22275 (comment).

After taking another look with fresh eyes, I think I see the "uncaught error" issue I initially noticed was here:

react/packages/react-devtools-shared/src/inspectedElementCache.js

Lines 178 to 195 in 8f96c6b

	inspectElementMutableSource({
	bridge,
	element,
	path: null,
	rendererID: ((rendererID: any): number),
	}).then(
	([
	inspectedElement: InspectedElementFrontend,
	responseType: InspectedElementResponseType,
	]) => {
	if (responseType === 'full-data') {
	startTransition(() => {
	const [key, value] = createCacheSeed(element, inspectedElement);
	refresh(key, value);
	});
	}
	},
	);

[jstejada]

thanks for following up on this, and submitting as a separate PR!

not a big deal, but since the original commit landed against main, wouldn't it be easier to land this revert on main directly, instead of stacking on top #22263? it seems like #22263 only has a simple change on hookNamesCache.js, so i wouldn't expect it to produce any significant merge conflicts, but idk.

in any case, not a big deal, up to you

regarding the changes themselves, so if inspecting the element fails, we don't really show anything in the UI? what does that look like currently?

After taking another look with fresh eyes, I think I see the "uncaught error" issue I initially noticed was here:

did you verify if the case you were seeing before shows up now reported as a console.error after these changes?

[bvaughn]

not a big deal, but since the original commit landed against main, wouldn't it be easier to land this revert on main directly, instead of stacking on top #22263? it seems like #22263 only has a simple change on hookNamesCache.js, so i wouldn't expect it to produce any significant merge conflicts, but idk.

I can land #22263 first then this PR so they are separate.

regarding the changes themselves, so if inspecting the element fails, we don't really show anything in the UI? what does that look like currently?

It will show a red icon with a tooltip that the parsing failed.

did you verify if the case you were seeing before shows up now reported as a console.error after these changes?

Yup! At least it seemed to.

If we see another case where it's not handled, let's dig in and figure out how to fix it too 😄