Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build_devtools_and_process_artifacts to new workflow #22388

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Sep 21, 2021

This is the last CI job that needs to be migrated to the new workflow.

This is the last CI job that needs to be migrated to the new workflow.
@acdlite acdlite requested a review from bvaughn September 21, 2021 15:17
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 21, 2021
@acdlite acdlite changed the title Move build_devtools_and_process_artifacts Move build_devtools_and_process_artifacts to new workflow Sep 21, 2021
@sizebot
Copy link

sizebot commented Sep 21, 2021

Comparing: 7c60496...3ecda98

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.39 kB 127.39 kB = 40.59 kB 40.59 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.21 kB 130.21 kB = 41.51 kB 41.51 kB
facebook-www/ReactDOM-prod.classic.js = 405.44 kB 405.44 kB = 75.05 kB 75.05 kB
facebook-www/ReactDOM-prod.modern.js = 394.03 kB 394.03 kB = 73.34 kB 73.34 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.44 kB 405.44 kB = 75.05 kB 75.05 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 3ecda98

@acdlite acdlite force-pushed the migrate-ci-pack-devtools branch 2 times, most recently from 2441f76 to 3ecda98 Compare September 21, 2021 15:37
@acdlite acdlite marked this pull request as ready for review September 21, 2021 15:43
@acdlite acdlite merged commit baff3f2 into facebook:main Sep 21, 2021
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
This is the last CI job that needs to be migrated to the new workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants