Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js to latest v14.17.6 LTS #22401

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Conversation

cyntler
Copy link
Contributor

@cyntler cyntler commented Sep 22, 2021

Summary

I decided to update Node.js to the latest LTS version.
The change affects ci.json and the .nvmrc file.

How did you test this change?

I ran testing scripts (yarn test, yarn test --prod), building script (yarn build) and Flow types checking (yarn flow dom). Looks like is working fine.

@facebook-github-bot
Copy link

Hi @cyntler!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sizebot
Copy link

sizebot commented Sep 22, 2021

Comparing: 95502f7...9d5286a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.52 kB 129.52 kB = 41.28 kB 41.28 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 132.34 kB 132.34 kB = 42.22 kB 42.22 kB
facebook-www/ReactDOM-prod.classic.js = 411.10 kB 411.10 kB = 76.08 kB 76.08 kB
facebook-www/ReactDOM-prod.modern.js = 399.67 kB 399.67 kB = 74.37 kB 74.37 kB
facebook-www/ReactDOMForked-prod.classic.js = 411.10 kB 411.10 kB = 76.09 kB 76.09 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 9d5286a

@bvaughn
Copy link
Contributor

bvaughn commented Sep 22, 2021

I decided to update Node.js to the latest LTS version.

Why? What's the motivation for this change? :)

@cyntler
Copy link
Contributor Author

cyntler commented Sep 23, 2021

@bvaughn Okay, so I read this article: https://www.gumlet.com/blog/whats-new-in-node-14/ - Node version 14 updates V8 Runtime to the >8.1 version. In the article we can find information about improved performance thanks to the OSR caching (https://v8.dev/blog/v8-release-79#osr-caching). In Node 14, thanks to the V8 update, we also have optional chaining.
I saw that React has version 12, I decided to update to version 14. I saw that the scripts work, tests too. React is my favorite library, I was looking for something first to change. My dream is to become a contributor and help in development. I thought it might be a good start;)

@gaearon
Copy link
Collaborator

gaearon commented Sep 23, 2021

Thanks! I'm not sure if the nvmrc file is used by anything, but the CI change shouldn't hurt. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants