-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node.js to latest v14.17.6 LTS #22401
Conversation
Hi @cyntler! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
7d0a3b2
to
8352234
Compare
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
8352234
to
9d5286a
Compare
Comparing: 95502f7...9d5286a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Why? What's the motivation for this change? :) |
@bvaughn Okay, so I read this article: https://www.gumlet.com/blog/whats-new-in-node-14/ - Node version 14 updates V8 Runtime to the >8.1 version. In the article we can find information about improved performance thanks to the OSR caching (https://v8.dev/blog/v8-release-79#osr-caching). In Node 14, thanks to the V8 update, we also have optional chaining. |
Thanks! I'm not sure if the nvmrc file is used by anything, but the CI change shouldn't hurt. :) |
Summary
I decided to update Node.js to the latest LTS version.
The change affects ci.json and the .nvmrc file.
How did you test this change?
I ran testing scripts (
yarn test
,yarn test --prod
), building script (yarn build
) and Flow types checking (yarn flow dom
). Looks like is working fine.