-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add imageSizes
and imageSrcSet
to know props
#22550
Conversation
Comparing: cbc484b...64164e2 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Do we understand where the other attribute table changes (matching main) are coming from? Feels uncomfortable to proceed until we know we haven't had an accidental regression in the meantime. |
I guess that's really a question about #22522. |
Yep, #22522 should go in first. Though I'll rebase #22522 first to check if nothing changed in the meantime. And then I'll run the attribute fixture with the repo being checked at the point where we last updated them to see if the changes are indeed caused by browser updates. We should probably include the browser version that created the snapshot in the attribute fixture as well. |
08dc781
to
64164e2
Compare
* feat(react-dom): Add `imageSrcSet` * feat(react-dom): Add `imageSizes`
Summary
Adds
imageSizes
andimageSrcSet
to know props.Spec: https://html.spec.whatwg.org/multipage/semantics.html#the-link-element
Note that the capitalization of
imageSrcSet
doesn't match the DOM property but follows<img srcSet />
capitalization.How did you test this change?
fixtures/attribute-behavior