fix: document can be null
, not just undefined
#22695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Jest sets
document
tonull
, notundefined
(ordelete
which the test from #11677 does) when tearing down the env. https://github.com/facebook/jest/blob/95f49691d3472d8187640f1b703209b93c2bcecc/packages/jest-environment-jsdom/src/index.ts#L135-L136How did you test this change?
At work we get
sometimes. I've been unable to track down where in our code we're missing a teardown (unfortunately the stack only points to react internals, no trace back to user code), but the error can be cleaner 🙂