Make clearContainer clear entire document (documentElement, including head and body) so that we can fallback to client rendering document during hydration #22874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #22833 by making
clearContainer
clear the entire document instead of just the body so that we don't run intoUncaught DOMException: Failed to execute 'appendChild' on 'Node': Only one element on document allowed.
while trying to client render a full page intodocument
.How did you test this change?
I added a test for the issue being fixed which failed before this change, however I found an old PR discussion saying that legacy behavior was to only clear
body
but there aren't any tests for this behavior and I don't understand why we'd want this behavior? Users could just render intodocument.body
explicitly rather than relying on this weird behavior?Also worked in latest FireFox/Chrome/Safari.