Fix issue where updating <option> children of <select> element doesn't trigger getting selected attribute properly set.
#2289
Conversation
…t trigger getting `selected` attribute properly set. Includes (previously failing) test.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
#2241 should solve this case as well. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Yours is a much nicer fix, since the guts of |
|
@stephenjudkins Definitely, more tests are better :) Yep, let's keep this open for now until that PR is approved, just in-case . |
|
@stephenjudkins My other PR is accepted so I poached your test-case as we agreed, sorry we couldn't take this PR but thanks for contributing anyway! :) |
|
No, thank you for providing a more thorough and robust fix to the problem. I suspect there may have been more bugs hidden in the edge cases with the previous approach anyways. |
|
👍 |
4 participants
Includes (previously failing) test.