Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build both a partial renderer and fizz renderer of the legacy API for FB #22933

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

sebmarkbage
Copy link
Collaborator

This lets us test how the new architecture performs without comparing it to other infra changes related to streaming.

I renamed the streaming one to ReactDOMServerStreaming. The references to Fizz in www need to be updated to point to this file.

I'll open an adhoc sync with just those files.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 10, 2021
bundleTypes: __EXPERIMENTAL__
? [UMD_DEV, UMD_PROD, NODE_DEV, NODE_PROD]
: [UMD_DEV, UMD_PROD, NODE_DEV, NODE_PROD, FB_WWW_DEV, FB_WWW_PROD],
bundleTypes: [UMD_DEV, UMD_PROD, NODE_DEV, NODE_PROD, FB_WWW_DEV, FB_WWW_PROD],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The classic version has an override that pulls in from partial renderer.
https://github.com/facebook/react/blob/main/packages/react-dom/src/server/ReactDOMLegacyServerBrowser.classic.fb.js

The modern version has the same config but uses the Fizz legacy implementation.

@sizebot
Copy link

sizebot commented Dec 10, 2021

Comparing: 75d34aa...47e040c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.54 kB 129.54 kB = 41.51 kB 41.51 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 134.68 kB 134.68 kB = 43.02 kB 43.02 kB
facebook-www/ReactDOM-prod.classic.js = 427.78 kB 427.78 kB = 78.55 kB 78.55 kB
facebook-www/ReactDOM-prod.modern.js = 417.47 kB 417.47 kB = 77.07 kB 77.07 kB
facebook-www/ReactDOMForked-prod.classic.js = 427.78 kB 427.78 kB = 78.55 kB 78.55 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +∞% 0.00 kB 229.91 kB +∞% 0.00 kB 55.04 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +∞% 0.00 kB 76.22 kB +∞% 0.00 kB 16.30 kB
facebook-www/ReactDOMServer-prod.modern.js = 76.22 kB 74.18 kB = 16.30 kB 15.52 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMServerStreaming-dev.modern.js +∞% 0.00 kB 229.91 kB +∞% 0.00 kB 55.04 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +∞% 0.00 kB 76.22 kB +∞% 0.00 kB 16.30 kB
facebook-www/ReactDOMServer-dev.modern.js +1.60% 229.91 kB 233.59 kB +1.46% 55.04 kB 55.85 kB
facebook-www/ReactDOMServer-prod.modern.js = 76.22 kB 74.18 kB = 16.30 kB 15.52 kB

Generated by 🚫 dangerJS against 47e040c

@sebmarkbage sebmarkbage force-pushed the legacyfbfizz branch 2 times, most recently from 8ce4cff to 6c31274 Compare December 10, 2021 00:55
This lets us test how the new architecture performs without comparing it to
other infra changes related to streaming.

I renamed the streaming one to ReactDOMServerStreaming so the references
in www need to be updated.

I'll open an adhoc sync with just those files.
@sebmarkbage sebmarkbage merged commit cd1a3e9 into facebook:main Dec 15, 2021
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jan 10, 2022
Summary:
This sync includes the following changes:
- **[fe905f152](facebook/react@fe905f152 )**: Update package.json ([#22954](facebook/react#22954)) //<Jack Works>//
- **[3dc41d8a2](facebook/react@3dc41d8a2 )**: fix: parseExportNamesInto specifiers typo ([#22537](facebook/react#22537)) //<btea>//
- **[bd0a5dd68](facebook/react@bd0a5dd68 )**: #22988 - Fix Bug: license header in React 18 bundles contains vundefined ([#23004](facebook/react#23004)) //<Vitalie>//
- **[ceee524a8](facebook/react@ceee524a8 )**: Remove unnecessary clearContainer call ([#22979](facebook/react#22979)) //<Sebastian Markbåge>//
- **[cd1a3e9b5](facebook/react@cd1a3e9b5 )**: Build both a partial renderer and fizz renderer of the legacy API for FB ([#22933](facebook/react#22933)) //<Sebastian Markbåge>//

Changelog:
[General][Changed] - React Native sync for revisions a049aa0...fe905f1

jest_e2e[run_all_tests]

Reviewed By: rickhanlonii

Differential Revision: D33512179

fbshipit-source-id: c2df06c8af6bb674ea0c5524538259e6d6d98f78
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
… FB (facebook#22933)

This lets us test how the new architecture performs without comparing it to
other infra changes related to streaming.

I renamed the streaming one to ReactDOMServerStreaming so the references
in www need to be updated.

I'll open an adhoc sync with just those files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants