Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove object-assign polyfill #23351

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Remove object-assign polyfill #23351

merged 3 commits into from
Feb 24, 2022

Commits on Feb 23, 2022

  1. Remove object-assign polyfill 

    We really rely on a more modern environment where this is typically
polyfilled anyway and we don't officially support IE with more extensive
polyfilling anyway. So all environments should have the native version
by now.
    @sebmarkbage
    sebmarkbage committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    38623ae View commit details
    Browse the repository at this point in the history

  2. Use shared/assign instead of Object.assign in code 

    This is so that we have one cached local instance in the bundle.

Ideally we should have a compile do this for us but we already follow
this pattern with hasOwnProperty, isArray, Object.is etc.
    @sebmarkbage
    sebmarkbage committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    42c6a76 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Transform Object.assign to now use shared/assign 

    We need this to use the shared instance when Object.spread is used.
    @sebmarkbage
    sebmarkbage committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    18c0cfb View commit details
    Browse the repository at this point in the history