Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabric HostComponent as EventEmitter: support add/removeEventListener (unstable only) #23386

Merged
merged 18 commits into from
Mar 2, 2022
Merged

Fabric HostComponent as EventEmitter: support add/removeEventListener (unstable only) #23386

merged 18 commits into from
Mar 2, 2022

Commits on Feb 28, 2022

  1. Implement addEventListener and removeEventListener on Fabric HostComp… 

    …onent
    @JoshuaGross
    JoshuaGross committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    434adcc View commit details
    Browse the repository at this point in the history

  2. add files

    @JoshuaGross
    JoshuaGross committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    fc44017 View commit details
    Browse the repository at this point in the history

  3. re-add CustomEvent

    @JoshuaGross
    JoshuaGross committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    b852035 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2022

  1. fix flow

    @JoshuaGross
    JoshuaGross committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    cbe9457 View commit details
    Browse the repository at this point in the history

  2. Need to get CustomEvent from an import since it won't exist on the gl… 

    …obal scope by default
    @JoshuaGross
    JoshuaGross committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    a85bdf5 View commit details
    Browse the repository at this point in the history

  3. yarn prettier-all

    @JoshuaGross
    JoshuaGross committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    4dbbf5a View commit details
    Browse the repository at this point in the history

  4. use a mangled name consistently to refer to imperatively registered e… 

    …vent handlers
    @JoshuaGross
    JoshuaGross committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    f5c518d View commit details
    Browse the repository at this point in the history

  5. yarn prettier-all

    @JoshuaGross
    JoshuaGross committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    f4b835a View commit details
    Browse the repository at this point in the history

  6. fuzzy null check

    @JoshuaGross
    JoshuaGross committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    4ce290c View commit details
    Browse the repository at this point in the history

  7. fix capture phase event listener logic

    @JoshuaGross
    JoshuaGross committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    a1cd472 View commit details
    Browse the repository at this point in the history

  8. early exit from getEventListeners more often

    @JoshuaGross
    JoshuaGross committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    c135e37 View commit details
    Browse the repository at this point in the history

  9. make some optimizations to getEventListeners and the bridge plugin

    @JoshuaGross
    JoshuaGross committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    ea15053 View commit details
    Browse the repository at this point in the history

  10. fix accumulateInto logic

    @JoshuaGross
    JoshuaGross committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    39a0451 View commit details
    Browse the repository at this point in the history

  11. fix accumulateInto

    @JoshuaGross
    JoshuaGross committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    7d5ecac View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. Simplifying getListeners at the expense of perf for the non-hot path

    @JoshuaGross
    JoshuaGross committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    dd47e87 View commit details
    Browse the repository at this point in the history

  2. feedback

    @JoshuaGross
    JoshuaGross committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    9f22e9c View commit details
    Browse the repository at this point in the history

  3. fix impl of getListeners to correctly remove function

    @JoshuaGross
    JoshuaGross committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    5045281 View commit details
    Browse the repository at this point in the history

  4. pass all args in to event listeners

    @JoshuaGross
    JoshuaGross committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    15fc32a View commit details
    Browse the repository at this point in the history