Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm dependencies, fix browserify task #2349

Merged
merged 2 commits into from
Oct 15, 2014
Merged

Conversation

zpao
Copy link
Member

@zpao zpao commented Oct 14, 2014

Mostly this is just so we're using the latest packages for all of our dependencies. The browserify update was a bit of work to make sure we actually do the right thing. I started to remove our lodash dependency because it doesn't do much and @sebmarkbage complained. Of note: we need to use derequire ourselves as it was removed from browserify.

Reviewers: @spicyj @syranide

Test Plan: build it, open example, inspect output.

Also picked up a bit of JSON reformatting, presumably from npm >= 2

Test plan: build, run tests
@sophiebits
Copy link
Collaborator

Have a diff of the old/new built files?

@zpao
Copy link
Member Author

zpao commented Oct 15, 2014

For react.js - https://gist.github.com/zpao/bd773ac94f934f832dc0. JSXTransformer.js - https://gist.github.com/zpao/e4b0f43a565a48f56baf

and now that I'm looking at the JSXTransformer one, it looks like es3ify isn't actually happening. I guess I'll move it back to an after step instead of a transform...

@zpao
Copy link
Member Author

zpao commented Oct 15, 2014

reverted to using es3ify in after: https://gist.github.com/zpao/5322b74c978ab332f6d6

zpao added a commit that referenced this pull request Oct 15, 2014
Update npm dependencies, fix browserify task
@zpao zpao merged commit 58165df into facebook:master Oct 15, 2014
@zpao zpao deleted the update-deps branch October 30, 2014 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants