Support but warn on key={null} #2388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core/ReactElement.js
Outdated
Collaborator
Author
There was a problem hiding this comment.
well we don't really want to encourage people to leave off keys… but I can say that. :)
Fixes facebook#2386. Test Plan: jest
Collaborator
|
spyOn doesn't allow you to revert back to the original if you want to start failing again but it's fine. |
Collaborator
Author
|
Lots of other tests in the same file use spyOn… |
Collaborator
|
I guess spyOn doesn't callthrough by default so it should work. And I guess you can revert it. Just a sucky API. |
Collaborator
Collaborator
|
Unless they fail CI like this one... |
Collaborator
Author
|
@sebmarkbage Transient failure – retried and it works. |
Collaborator
|
cool. mergeit |
sophiebits
added a commit
that referenced
this pull request
Oct 21, 2014
Support but warn on key={null}
Member
As long as the milestone is 0.12, yes. Then once we cut we can apply that rule to master as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2386.
Test Plan: jest
Reviewers: @sebmarkbage