Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fizz] Don't flush empty segments #24054

Merged
merged 1 commit into from
Mar 9, 2022
Merged

[Fizz] Don't flush empty segments #24054

merged 1 commit into from
Mar 9, 2022

Commits on Mar 9, 2022

  1. [Fizz] Don't flush empty segments 

    Before this change, we would sometimes write segments without any content
in them. For example for a Suspense boundary that immediately suspends
we might emit something like:

<div hidden id="123">
  <template id="456"></template>
</div>

Where the outer div is just a temporary wrapper and the inner one is a
placeholder for something to be added later.

This serves no purpose.

We should ideally have a heuristic that holds back segments based on byte
size and time. However, this is a straight forward clear win for now.
    @sebmarkbage
    sebmarkbage committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    b9a1049 View commit details
    Browse the repository at this point in the history