Test :Add a small test for ReactTestUtils to find rendered component with type in document #24368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Biki-das
changed the title
…h type in document
|
Comparing: 168da8d...ddc77ac Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
@gaearon could you. Review? |
Biki-das
changed the title
rickhanlonii
approved these changes
Apr 14, 2022
Also added some tests one month back to the react ART package too 😀 |
|
hey @rickhanlonii is it good to go , or there are some nits? |
|
@gaearon friendly ping :-) |
|
See #21309 |
|
@lunaruan could you review? |
|
hey @sebmarkbage could you review! |
|
hey @eps1lon seems like this can go forward as it's already been approved looking forward to your thoughts |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
…with type in document (#24368) I tried to write test for the ReactTestUtils to find rendered component with type in document Tests before this PR  Tests after this PR  DiffTrain build for [4fcc918](4fcc918) [View git log for this commit](https://github.com/facebook/react/commits/4fcc9184ac2662186cbf1470005bf2b7c67dd40b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to write test for the ReactTestUtils to find rendered component with type in document
Tests before this PR
Tests after this PR