Fixes autofocus does not work when the dialog has opened #24376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* __DEV__ condition removed from update container because onScheduleRoot has already a __DEV__ condition. * Removed __DEV__ condition in catch scope.
This reverts commit 86133d4.
|
Comparing: 1f7a901...ba5622a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
@rickhanlonii can you review this please |
gaearon
requested changes
Apr 14, 2022
|
My purpose focus to the element which has autoFocus prop when a dialog opens. dialog is being rendered on the first mount even if not visible. React is being looked at to elements that have autoFocus property only first mount. I look up again to children that have autoFocus property when the dialog has opened. |
|
Can I do that? Where do I put begin and complete methods? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #23301. Dialog elements already have been rendered when the open props value has changed.
How did you test this change?
I have tried the dispatchEvent but that can't render properly. The important point is the input element should have autoFocus={true} property before open the dialog.