-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React DOM: Add support for hidden="until-found"
#24741
Conversation
| `hidden=(empty string)`| (initial)| `<boolean: false>` | | ||
| `hidden=(empty string)`| (changed)| `<boolean: true>` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar issue as #24730: Should this be behind a flag?
Comparing: 4cd788a...eb16b74 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
1902bcf
to
eb16b74
Compare
4550628
to
ea40625
Compare
Comparing: 01ab35a...a7cc853 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
ea40625
to
c54cb92
Compare
c54cb92
to
8f5e56c
Compare
We'll also need to look into support for |
8f5e56c
to
a7cc853
Compare
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Summary
Closes #24740
Adds support for the experimental
hidden="until-found"
as well as the correspondig TODOonBeforeMatch
event handler.Keep in mind that these new browser APIs are only implemented in Chrome and Edge at the moment. Safari and Firefox have no support for this API yet (see
hidden
browser compatibility table.I haven't checked if we can polyfill the API or maybe we shouldn't even do that? Otherwise landing this would take more time and block experimentation in UIs targetting Chromium exclusively
How did you test this change?