use-sync-external-store: Add exports field to package.json
#25231
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 1e3e30d...360fe3d Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
force-pushed
the
feat/uSES-export
branch
from
8cd5c8c to
3cf0eb2
Compare
eps1lon
changed the title
exports field to package.jsonexports field to package.json
eps1lon
force-pushed
the
feat/uSES-export
branch
from
3cf0eb2 to
62a5371
Compare
eps1lon
commented
Sep 10, 2022
| "react-native": "./shim/index.native.js", | ||
| "default": "./shim/index.js" | ||
| }, | ||
| "./shim/index.native": "./shim/index.native.js", |
There was a problem hiding this comment.
For compat with bundlers that don't support the react-native condition. Though I don't know if we need it. I just copied it from #24440
There was a problem hiding this comment.
https://github.com/facebook/react/blob/main/packages/use-sync-external-store/src/__tests__/useSyncExternalStoreNative-test.js#L45
It seems that this entry has been used in several places. I'm not sure if this is necessary.
Andarist
reviewed
Sep 13, 2022
packages/use-sync-external-store/src/useSyncExternalStoreWithSelector.js
Outdated
Show resolved
Hide resolved
eps1lon
force-pushed
the
feat/uSES-export
branch
from
62a5371 to
360fe3d
Compare
This was referenced Jan 6, 2023
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
Resolution: Stale
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
Resolution: Stale
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
Resolution: Stale
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
Resolution: Stale
1 task
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
Resolution: Stale
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
Resolution: Stale
This comment was marked as resolved.
This comment was marked as resolved.
dfltr
added a commit
to FrigadeHQ/javascript
that referenced
this pull request
Dec 9, 2024
eps1lon
force-pushed
the
feat/uSES-export
branch
from
360fe3d to
f7f5817
Compare
github-actions
bot
added
the
React Core Team
eps1lon
force-pushed
the
feat/uSES-export
branch
from
f7f5817 to
4b94040
Compare
eps1lon
commented
Feb 4, 2025
There was a problem hiding this comment.
Matches the layout we have in ./npm
eps1lon
force-pushed
the
feat/uSES-export
branch
from
4b94040 to
d77e5f6
Compare
These are the likely candidates of public entrypoints to have been used with strict module resolution. `./cjs/` is not supported because that means you'd be able to choose dev vs prod which you shouldn't.
|
@markerikson Does this change work for you? |
|
Haven't had a chance to test it out specifically, but the change looks reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24590
Closes #26230
Summary
Adds
exportsfields for the following entrypoints:There's an argument to be made that this should be a SemVer MAJOR e.g.
use-sync-external-store/cjs/*no longer works. I wouldn't consider these part of the public interface though. If we make it SemVer major we can remove all the legacy entrypoints. Feels a bit too disruptive for this feature. With support for legacy entrypoints this should be non-breaking. So a SemVer MAJOR punishes the libraries using public entrypoints just to safeguard the ones using internals.How did you test this change?