Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RulesOfHooks-test more consistent with ExhaustiveDeps-test #25369

Closed
wants to merge 1 commit into from

Conversation

poteto
Copy link
Member

@poteto poteto commented Sep 30, 2022

Small formatting changes to make the tests consistent.

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 30, 2022
@sizebot
Copy link

sizebot commented Sep 30, 2022

Comparing: abbbdf4...0e1baca

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 135.28 kB 135.28 kB = 43.39 kB 43.39 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 142.91 kB 142.91 kB = 45.61 kB 45.61 kB
facebook-www/ReactDOM-prod.classic.js = 491.42 kB 491.42 kB = 87.45 kB 87.45 kB
facebook-www/ReactDOM-prod.modern.js = 476.71 kB 476.71 kB = 85.25 kB 85.25 kB
facebook-www/ReactDOMForked-prod.classic.js = 491.42 kB 491.42 kB = 87.45 kB 87.45 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0e1baca

@poteto poteto closed this in 06066c1 Sep 30, 2022
@poteto poteto deleted the gh/poteto/2/head branch September 30, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants