Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow upgrade to 0.143 #25408

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Flow upgrade to 0.143 #25408

merged 1 commit into from
Oct 4, 2022

Conversation

kassens
Copy link
Member

@kassens kassens commented Oct 4, 2022

Stack from ghstack (oldest at bottom):

This was a large upgrade that removed "classic mode" and made "types first" the only option.
Most of the needed changes have been done in previous PRs, this just fixes up the last few instances.

This was a large upgrade that removed "classic mode" and made "types first" the only option.
Most of the needed changes have been done in previous PRs, this just fixes up the last few instances.

[ghstack-poisoned]
This was referenced Oct 4, 2022
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Oct 4, 2022
kassens added a commit to kassens/react that referenced this pull request Oct 4, 2022
This was a large upgrade that removed "classic mode" and made "types first" the only option.
Most of the needed changes have been done in previous PRs, this just fixes up the last few instances.

ghstack-source-id: 9612d95ba4b32edeb73fee8be9f3d67c43e86b80
Pull Request resolved: facebook#25408
@sizebot
Copy link

sizebot commented Oct 4, 2022

Comparing: 0a30722...2fd582a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 135.46 kB 135.46 kB = 43.41 kB 43.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 147.72 kB 147.72 kB = 47.17 kB 47.17 kB
facebook-www/ReactDOM-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB
facebook-www/ReactDOM-prod.modern.js = 477.00 kB 477.00 kB = 85.24 kB 85.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 2fd582a

@kassens kassens merged commit 2fd582a into gh/kassens/1/base Oct 4, 2022
@kassens kassens deleted the gh/kassens/1/head branch October 4, 2022 15:02
kassens added a commit that referenced this pull request Oct 4, 2022
This was a large upgrade that removed "classic mode" and made "types first" the only option.
Most of the needed changes have been done in previous PRs, this just fixes up the last few instances.

ghstack-source-id: 9612d95ba4b32edeb73fee8be9f3d67c43e86b80
Pull Request resolved: #25408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants