Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow upgrade to 0.155 #25414

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Flow upgrade to 0.155 #25414

merged 2 commits into from
Oct 4, 2022

Conversation

kassens
Copy link
Member

@kassens kassens commented Oct 4, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

This version banned use of this in object functions.

@kassens
Flow upgrade to 0.155
78167b2 
This version banned use of this in object functions.

[ghstack-poisoned]
This was referenced Oct 4, 2022
Merged
Merged
Merged
kassens added a commit that referenced this pull request Oct 4, 2022
@kassens
Flow upgrade to 0.155
14be04f 
This version banned use of this in object functions.

ghstack-source-id: 6c1e711302e8cafac87d292a3aeecff7ca529e00
Pull Request resolved: #25414
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 4, 2022
@sizebot
Copy link

sizebot commented Oct 4, 2022 •
edited
Loading

Comparing: 9f8a98a...a4f42f2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 135.46 kB 135.46 kB = 43.41 kB 43.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 147.72 kB 147.72 kB = 47.17 kB 47.17 kB
facebook-www/ReactDOM-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB
facebook-www/ReactDOM-prod.modern.js = 477.00 kB 477.00 kB = 85.24 kB 85.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB
oss-experimental/react-fetch/cjs/react-fetch.browser.development.js +17.85% 3.43 kB 4.04 kB +5.44% 1.16 kB 1.22 kB
oss-stable-semver/react-fetch/cjs/react-fetch.browser.development.js +17.85% 3.43 kB 4.04 kB +5.44% 1.16 kB 1.22 kB
oss-stable/react-fetch/cjs/react-fetch.browser.development.js +17.85% 3.43 kB 4.04 kB +5.44% 1.16 kB 1.22 kB
oss-experimental/react-fetch/cjs/react-fetch.node.development.js +11.68% 5.09 kB 5.69 kB +3.50% 1.63 kB 1.69 kB
oss-stable-semver/react-fetch/cjs/react-fetch.node.development.js +11.68% 5.09 kB 5.69 kB +3.50% 1.63 kB 1.69 kB
oss-stable/react-fetch/cjs/react-fetch.node.development.js +11.68% 5.09 kB 5.69 kB +3.50% 1.63 kB 1.69 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-fetch/cjs/react-fetch.browser.development.js +17.85% 3.43 kB 4.04 kB +5.44% 1.16 kB 1.22 kB
oss-stable-semver/react-fetch/cjs/react-fetch.browser.development.js +17.85% 3.43 kB 4.04 kB +5.44% 1.16 kB 1.22 kB
oss-stable/react-fetch/cjs/react-fetch.browser.development.js +17.85% 3.43 kB 4.04 kB +5.44% 1.16 kB 1.22 kB
oss-experimental/react-fetch/cjs/react-fetch.node.development.js +11.68% 5.09 kB 5.69 kB +3.50% 1.63 kB 1.69 kB
oss-stable-semver/react-fetch/cjs/react-fetch.node.development.js +11.68% 5.09 kB 5.69 kB +3.50% 1.63 kB 1.69 kB
oss-stable/react-fetch/cjs/react-fetch.node.development.js +11.68% 5.09 kB 5.69 kB +3.50% 1.63 kB 1.69 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js +0.57% 5.64 kB 5.67 kB +1.49% 1.81 kB 1.84 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js +0.57% 5.64 kB 5.67 kB +1.49% 1.81 kB 1.84 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js +0.57% 5.64 kB 5.67 kB +1.49% 1.81 kB 1.84 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js +0.56% 5.70 kB 5.73 kB +1.37% 1.83 kB 1.85 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js +0.56% 5.70 kB 5.73 kB +1.37% 1.83 kB 1.85 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js +0.56% 5.70 kB 5.73 kB +1.37% 1.83 kB 1.85 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js +0.41% 7.83 kB 7.87 kB +0.84% 3.09 kB 3.11 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js +0.41% 7.83 kB 7.87 kB +0.84% 3.09 kB 3.11 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js +0.41% 7.83 kB 7.87 kB +0.84% 3.09 kB 3.11 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.development.js +0.38% 8.42 kB 8.45 kB +0.82% 3.19 kB 3.21 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.development.js +0.38% 8.42 kB 8.45 kB +0.82% 3.19 kB 3.21 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.development.js +0.38% 8.42 kB 8.45 kB +0.82% 3.19 kB 3.21 kB

Generated by 🚫 dangerJS against a4f42f2

@kassens
Update on "Flow upgrade to 0.155"
a4f42f2 
This version banned use of this in object functions.

[ghstack-poisoned]
kassens added a commit that referenced this pull request Oct 4, 2022
@kassens
Flow upgrade to 0.155
cdeffb4 
This version banned use of this in object functions.

ghstack-source-id: f49fd5e1b7732cea1ec75e71f2611f0ffa19e80d
Pull Request resolved: #25414
@kassens kassens merged commit a4f42f2 into gh/kassens/4/base Oct 4, 2022
kassens added a commit that referenced this pull request Oct 4, 2022
@kassens
Flow upgrade to 0.155
338e6a9 
This version banned use of this in object functions.

ghstack-source-id: f49fd5e1b7732cea1ec75e71f2611f0ffa19e80d
Pull Request resolved: #25414
@kassens kassens deleted the gh/kassens/4/head branch October 4, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kassens @sizebot @gaearon @facebook-github-bot