Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: LegacyHidden shouldn't defer effects #25442

Merged
merged 1 commit into from
Oct 6, 2022

Commits on Oct 6, 2022

  1. Bugfix: LegacyHidden shouldn't defer effects

    In facebook#24967, I changed the behavior of Offscreen so that passive effects
    are not fired when the tree is hidden. I accidentally applied this
    behavior to the old LegacyHidden API, too, which is a deprecated
    internal-only type that www has been using while they wait for Offscreen
    to be ready.
    
    This fixes LegacyHidden so that the effects do not get deferred, like
    before. The new behavior still remains in the Offscreen API, which is
    experimental and not currently in use in www.
    acdlite committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    60017f1 View commit details
    Browse the repository at this point in the history