[DiffTrain] Add github url for the commit to the commit message #25845
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: bfcbf33...bede698 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
@sophiebits yay thanks :) do you mean including a changelog of all the commits included (like we had in the old sync script)? Our new DiffTrain integration syncs each commit individually so the log wouldn't be useful. Let me know if I'm misunderstanding though! |
|
In the URL if you do “commits” instead of “commit” then it will show the preceding commits as well. I was thinking that might be helpful if you’re checking a commit and trying to think of if some other particular commit preceded it / was included in that bundle. I’m sure you have a better mental picture though! |
|
Ooh nice - let's add both! |
poteto
force-pushed
the
lt/difftrain-url
branch
from
77416b9
to
bede698
Compare
Currently we just append the ref for the commit, let's make it clickable for easier debugging in syncs. DiffTrain build for [1c7055d](1c7055d) [View git log for this commit](https://github.com/facebook/react/commits/1c7055ddbbdae81224f998e42832d882fde06686)
Currently we just append the ref for the commit, let's make it clickable for easier debugging in syncs.