Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Error Messages when Access Client References #26059

Merged
merged 4 commits into from
Jan 28, 2023
Merged

Improve Error Messages when Access Client References #26059

merged 4 commits into from
Jan 28, 2023

Commits on Jan 27, 2023

  1. Rename ModuleReference to ClientReference

    @sebmarkbage
    sebmarkbage committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    3e1c56e View commit details
    Browse the repository at this point in the history

  2. Use functions as Client References instead 

    This lets us throw better errors when they're used as a function.
    @sebmarkbage
    sebmarkbage committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    aef6f1d View commit details
    Browse the repository at this point in the history

  3. Ensure passing a client reference to use() unwraps it as a promise 

    This isn't quite right if this is a Context or otherwise but we could
change the async flag on module references to use the use() unwrapping
instead.

Give a better error for passing a client reference to useContext.
    @sebmarkbage
    sebmarkbage committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    912eeb4 View commit details
    Browse the repository at this point in the history

  4. Throw when accessing a deep member below the direct exports

    @sebmarkbage
    sebmarkbage committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    d50a23a View commit details
    Browse the repository at this point in the history