Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish-prereleases: Exit if CircleCI request fails #26100

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Feb 2, 2023

If the publish-prereleases command fails to access CircleCI, it will now exit with a message instead of hanging indefinitely.

If the publish-prereleases command fails to access CircleCI, it will
now exit with a message instead of hanging indefinitely.
@acdlite acdlite requested a review from sebmarkbage February 2, 2023 23:38
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 2, 2023
@react-sizebot
Copy link

Comparing: 2ef2414...a630684

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.84 kB 154.84 kB = 49.12 kB 49.12 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.85 kB 156.85 kB = 49.78 kB 49.78 kB
facebook-www/ReactDOM-prod.classic.js = 533.79 kB 533.79 kB = 95.06 kB 95.06 kB
facebook-www/ReactDOM-prod.modern.js = 518.81 kB 518.81 kB = 92.82 kB 92.82 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against a630684

@acdlite acdlite merged commit 855b77c into facebook:main Feb 3, 2023
github-actions bot pushed a commit that referenced this pull request Feb 3, 2023
If the publish-prereleases command fails to access CircleCI, it will now
exit with a message instead of hanging indefinitely.

DiffTrain build for [855b77c](855b77c)
[View git log for this commit](https://github.com/facebook/react/commits/855b77c9bbee347735efcd626dda362db2ffae1d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants