Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and update attribute-behavior fixture #26114

Merged
merged 6 commits into from
Feb 10, 2023
Merged

Fix and update attribute-behavior fixture #26114

merged 6 commits into from
Feb 10, 2023

Commits on Feb 10, 2023

  1. Update attribute-behavior snapshot (except <meta>) 

    Ran without `<meta>` tags which currently crash
the fixture
    @eps1lon
    eps1lon committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    ab71467 View commit details
    Browse the repository at this point in the history

  2. Ensure Stable and Next have use same server impl

    @eps1lon
    eps1lon committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    d0032ab View commit details
    Browse the repository at this point in the history

  3. Render valid meta tags

    @eps1lon
    eps1lon committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    0de4cde View commit details
    Browse the repository at this point in the history

  4. Verify html[version] result by adding html[lang] 

    `version` is obsolete so I was hoping this result doesn't matter.
But `lang`  has the same behavior i.e. isn't added to the DOM on the client
    @eps1lon
    eps1lon committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    587810d View commit details
    Browse the repository at this point in the history

  5. Ensure we find the rendered element if we render into document

    @eps1lon
    eps1lon committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9a2f7f7 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary extraProps

    @eps1lon
    eps1lon committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    dfb5f26 View commit details
    Browse the repository at this point in the history