Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't recommend deprecated debugger script #26171

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

Biki-das
Copy link
Contributor

yarn debug-test is now deprecated in React package.json. It has been replaced by yarn test --debug.

Untitled.mp4

@Biki-das
Copy link
Contributor Author

@eps1lon could you review?

@react-sizebot
Copy link

Comparing: fccf3a9...1be5585

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.54 kB 154.54 kB = 48.83 kB 48.83 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.54 kB 156.54 kB = 49.45 kB 49.45 kB
facebook-www/ReactDOM-prod.classic.js = 529.73 kB 529.73 kB = 94.36 kB 94.36 kB
facebook-www/ReactDOM-prod.modern.js = 514.95 kB 514.95 kB = 92.17 kB 92.17 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 1be5585

Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@eps1lon eps1lon changed the title Fixed wrong debugger command Don't recommend deprecated debugger script Feb 16, 2023
@eps1lon eps1lon merged commit 2f40170 into facebook:main Feb 16, 2023
@Biki-das Biki-das deleted the contrib-docs branch February 16, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants