Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change commit message for DiffTrain commigs #26203

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Change commit message for DiffTrain commigs #26203

merged 1 commit into from
Feb 20, 2023

Conversation

sammy-SC
Copy link
Contributor

@sammy-SC sammy-SC commented Feb 20, 2023 •
edited
Loading

Previously, the commit message looked something like this in Github:
Screenshot 2023-02-20 at 13 52 35

With this change, it will look like:

DiffTrain build for commit db5e625.

@sammy-SC sammy-SC requested a review from poteto February 20, 2023 13:54
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 20, 2023
@react-sizebot
Copy link

Comparing: 6b6d061...9611e24

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.55 kB 154.55 kB = 48.84 kB 48.84 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.55 kB 156.55 kB = 49.46 kB 49.46 kB
facebook-www/ReactDOM-prod.classic.js = 531.43 kB 531.43 kB = 94.72 kB 94.72 kB
facebook-www/ReactDOM-prod.modern.js = 515.39 kB 515.39 kB = 92.26 kB 92.26 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 9611e24

@sammy-SC sammy-SC merged commit 2cc54b5 into facebook:main Feb 20, 2023
@sammy-SC sammy-SC deleted the change-difftrain-commit-message branch February 20, 2023 15:17
github-actions bot pushed a commit that referenced this pull request Feb 20, 2023
@sammy-SC
Change commit message for DiffTrain commigs (#26203)
ef43b87 
Previously, the commit message looked something like this in Github:
<img width="921" alt="Screenshot 2023-02-20 at 13 52 35"
src="https://user-images.githubusercontent.com/1733610/220126265-d77931e0-18ac-46a0-bf23-d868f8af17a9.png">

With this change, it will look like:

DiffTrain build for commit db5e625.

DiffTrain build for commit 2cc54b5.
@sammy-SC sammy-SC mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@poteto poteto Awaiting requested review from poteto

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sammy-SC @react-sizebot @eps1lon @facebook-github-bot