Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codesandbox: upgrade to Node.js 18 #26330

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Codesandbox: upgrade to Node.js 18 #26330

merged 1 commit into from
Mar 6, 2023

Conversation

kassens
Copy link
Member

@kassens kassens commented Mar 6, 2023 •
edited
Loading

Turns out Codesandbox didn't support String.prototype.replaceAll in #26329.

This updates the config to use Node.js 18 for Codesandbox builds.

@kassens kassens requested review from gaearon and acdlite March 6, 2023 20:29
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 6, 2023
@react-sizebot
Copy link

Comparing: 6e1756a...1aac4d1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 155.28 kB 155.28 kB = 48.98 kB 48.98 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 157.27 kB 157.27 kB = 49.66 kB 49.66 kB
facebook-www/ReactDOM-prod.classic.js = 532.65 kB 532.65 kB = 94.87 kB 94.87 kB
facebook-www/ReactDOM-prod.modern.js = 516.58 kB 516.58 kB = 92.47 kB 92.47 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 1aac4d1

@kassens kassens merged commit 88313ff into facebook:main Mar 6, 2023
@kassens kassens deleted the codesandbox-node-18 branch March 6, 2023 20:38
github-actions bot pushed a commit that referenced this pull request Mar 6, 2023
@kassens
Codesandbox: upgrade to Node.js 18 (#26330)
a1c7473 
Turns out Codesandbox didn't support `String.prototype.replaceAll` in
#26329.

This updates the config to use Node.js 18 for Codesandbox builds.

DiffTrain build for [88313ff](88313ff)
@sammy-SC sammy-SC mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kassens @react-sizebot @acdlite @facebook-github-bot