Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] prevent StyleX plugin from throwing when inspecting CSS #26364

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

mondaychen
Copy link
Contributor

@mondaychen mondaychen commented Mar 10, 2023

Summary

An error might happen when we try to read the CSS rules, but the stylesheet does not allow so (often happens on production).

Before:
image

After:

image

How did you test this change?

Built a fb version and tested locally (see above screenshot)


@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 10, 2023
@mondaychen mondaychen requested a review from tyao1 March 10, 2023 17:00
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
@mondaychen mondaychen merged commit a22bd99 into facebook:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants