Add missing "react-dom/server.bun"
entry in package.json "exports"
#26402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
react-dom/server
in Bun (correctly) choosesreact-dom/server.bun
, butreact-dom/server.bun
currently can't be imported because it is not included in package.json"exports"
(react-dom/server
works,react-dom/server.bun
doesn't). Previously, I didn't think it was necessary to do that, but it is too easy to accidentally run the browser build in unit tests when importingreact-dom/server
This also aligns behavior of package.json
"exports"
ofreact-dom/server.bun
withreact-dom/server.browser
,react-dom/server.node
, and the rest.How did you test this change?
Manually edited package.json in node_modules in a separate folder and ran tests in Bun with
react-dom/server.bun
as the import specifier