-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix suspense replaying forwardRefs #26420
Conversation
Hi @hansottowirtz! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@acdlite Should be good to go apart from maybe the location/name/content of the test, let me know. |
Please don't merge yet, this also caused #26419. I will update the PR. |
Gonna need some help here, |
Can you rebase that onto master? Then CI should run |
I rebased, but it seems like there's some kind of circleci config missing. |
Running the test locally still fails. The underlying issue is quite clear (suspense replay logic for ForwardRef was just not implemented) but I'm not sure how to fix it. |
I took another look at it and I think I fixed it, so it should be good to go. |
Try creating a branch and request a pull request from there instead of using your Manually triggered the pipeline now |
Replaced by #26535 |
Continuation of facebook/react#26420 Fixes facebook/react#26385 and facebook/react#26419 --------- Co-authored-by: eps1lon <silbermann.sebastian@gmail.com> Co-authored-by: Andrew Clark <git@andrewclark.io> DiffTrain build for [7329ea81c154d40800e30104be40f050e8c2af3e](facebook/react@7329ea8)
Continuation of facebook#26420 Fixes facebook#26385 and facebook#26419 --------- Co-authored-by: eps1lon <silbermann.sebastian@gmail.com> Co-authored-by: Andrew Clark <git@andrewclark.io>
@acdlite Fixes #26385