Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REVISION file to react-fbsource-import #26448

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

sammy-SC
Copy link
Contributor

For DiffTrain to fbsource, we need REVISION file in compiled-rn folder

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 21, 2023
@sammy-SC sammy-SC requested review from poteto and rickhanlonii March 21, 2023 15:21
@react-sizebot
Copy link

Comparing: 12a1d14...060d941

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 159.26 kB 159.26 kB = 50.45 kB 50.45 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 161.00 kB 161.00 kB = 50.96 kB 50.96 kB
facebook-www/ReactDOM-prod.classic.js = 546.50 kB 546.50 kB = 96.87 kB 96.87 kB
facebook-www/ReactDOM-prod.modern.js = 530.21 kB 530.21 kB = 94.42 kB 94.42 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 060d941

@sammy-SC sammy-SC merged commit 0018cf2 into facebook:main Mar 21, 2023
@sammy-SC sammy-SC deleted the add-revision-file-to-fbsource-sync branch March 21, 2023 16:18
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
For DiffTrain to fbsource, we need REVISION file in compiled-rn folder

DiffTrain build for commit 0018cf2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants