Skip to content

[DevTools] Replace deprecated new-window with webContents.setWindowOpenHandler() #26559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2023
Merged

[DevTools] Replace deprecated new-window with webContents.setWindowOpenHandler() #26559

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59c1a18
Replace deprecated new-window with setWindowOpenHandler
Willie-Boy Apr 5, 2023
fa17476
Import shell and run yarn prettier-all
Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-devtools/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* LICENSE file in the root directory of this source tree.
*/

const {app, BrowserWindow} = require('electron'); // Module to create native browser window.
const {app, BrowserWindow, shell} = require('electron'); // Module to create native browser window.
const {join} = require('path');
const os = require('os');

Expand Down Expand Up @@ -40,9 +40,9 @@ app.on('ready', function () {
}

// https://stackoverflow.com/questions/32402327/
mainWindow.webContents.on('new-window', function (event, url) {
event.preventDefault();
require('electron').shell.openExternal(url);
mainWindow.webContents.setWindowOpenHandler(({url}) => {
shell.openExternal(url);
return {action: 'deny'};
});

// and load the index.html of the app.
Expand Down