Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] waitForThrow should diff strings #26568

Merged
merged 1 commit into from
Apr 7, 2023
Merged

[Tests] waitForThrow should diff strings #26568

merged 1 commit into from
Apr 7, 2023

Commits on Apr 6, 2023

  1. waitForThrow should diff strings 

    Currently, `waitForThrow` tries to diff the expected value against the thrown value if it doesn't match. However if the expectation is a string, we are not diffing against the thrown message. This commit makes it so if we are matching against message we also diff against message.
    @gnoff
    gnoff committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    6dfbd27 View commit details
    Browse the repository at this point in the history