-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Popover API support #27480
Add Popover API support #27480
Conversation
Comparing: dddfe68...3578155 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
@Semigradsky thanks for the updates here. #27717 should fix the error from the fixtures app. If you rebase on main you should be able to update the attributes fixture now |
@jackpope Now in
Document title is |
The img tag error appears to be flaky. I get it on some loads but others complete successfully. We should fix this but for the sake of getting this PR merged soon, could you try a few more attempts at recording the fixture here? |
@jackpope I have tried several times (more than 5 already) and I always have this error. |
i’m very excited for this to land! the browser console errors and linting errors are painful. @Semigradsky @jackpope do either of you know how much of a lift it would be to extend support to include the new |
Alternate with proper overrides for the attribute-behavior fixture and support for the beforetoggle and toggle events: #27981 |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Fixed in #27981 |
Would be great if this was added to React 18 |
Summary
Closes #27479
I tried to update
fixtures/attribute-behavior/AttributeTableSnapshot.md
but I got error in browser console: