-
Notifications
You must be signed in to change notification settings - Fork 48.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial canary changelog #27504
Add initial canary changelog #27504
Conversation
Comparing: e61a60f...6644d63 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
In addition to what Andrew raised, how are people meant to update this when making changes? You won't know what version it is until after it's merged, and also you will get merge conflicts galore if many PRs change this file. One possibility might be to generate from commit messages somehow. Another that I have seen projects use is to add changelog entries to a hidden folder in the repo root with an autogenerated file name (like The other thought I had is what if you change some behavior from A to B in canary, then from B to C later. If someone is consuming canaries then they want to hear about both of these but if they are coming to canary from stable (or if we're generating the stable release notes) then we only want to mention the change from A to C, not two changelog entries. Or are there just not gonna be that many entries and I'm overthinking it. (Sorry if any or all of this has been discussed already and I missed it.) |
This are all great points. Thank you for all these thoughts. My thought with creating this was that there shouldn't be too many changes to the canary since there is a fairly high bar for adding things to canary. I was thinking that we don't need to couple changes in React to updating the changelog and that a PR to update the changelog could come later. I was thinking that the main audience for the canary change logs would be framework and library authors that are doing 1 of 2 things:
The reason this is being created now is so we have a place to canonical place to tell devs when features are ready for adoption by libs and frameworks. Namely server actions were recently promoted to the canary release channel and we don't have a place to document this at the moment hence this PR. @acdlite expressed an interest on another channel in having similar info on react.dev instead of in this repo. If we want to do something more complex (e.g. a autogenerated change log) I think we should look at creating a flow that publishes nicely formatted change logs to react.dev. But this would be a non-trival undertaking (e.g. most of the canary changes to enable server actions were just flag flips, the code was already in the release). I hadn't considered the audience that is coming from a stable release to a canary release but I imagine we could cover this use case with a automated changelog script. I think I'd still like to merge this PR as a stopgap so we have a place to document canary changes and look into a better solution long term after we get the server action documentation finished on React.dev. |
If all you're worried about is giant features then sure let's update it manually and only occasionally. If we want lists of bugfixes like our release changelogs typically have (even canary consumers may be interested in when bugs they have run into get fixed) then we'll need a better process I think. |
Had a chat with @acdlite offline, I'll merge this for now and we'll explore better options moving forward. |
React upstream changes: - facebook/react#27570 - facebook/react#27569 - facebook/react#27550 - facebook/react#27559 - facebook/react#27552 - facebook/react#27504 - facebook/react#27522 Co-authored-by: Josh Story <2716369+gnoff@users.noreply.github.com>
DiffTrain build for commit b9244f7.
No description provided.