refactor[ci/build]: dont generate sourcemaps for BROWSER_SCRIPT bundles #27665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 52d542a...4de1e44 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Collaborator
|
|
Contributor
Author
Yes, it is |
kassens
approved these changes
Nov 9, 2023
hoxyq
deleted the
build/exclude-browser-scripts-from-generating-sourcemaps
branch
github-actions bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
…es (#27665) Instead of #27664, we can just exclude `unstable_server-external-runtime.js` from having sourcemaps for now. We should consider removing manual copying of this artifact in https://github.com/facebook/react/blob/52d542ad6d410008c495084f511247f43387055f/.github/workflows/commit_artifacts.yml#L136-L138 As described in #27664, this artifact doesn't have any effect on the `hash`, which is used for generating React version identifier. DiffTrain build for [78c71bc](78c71bc)
gnoff
added a commit
to gnoff/next.js
that referenced
this pull request
Nov 10, 2023
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 10, 2023
Updates React from 746890329 to 0e352ea01. - facebook/react#27684 - facebook/react#27665 - facebook/react#27671 - facebook/react#27680
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…es (facebook#27665) Instead of facebook#27664, we can just exclude `unstable_server-external-runtime.js` from having sourcemaps for now. We should consider removing manual copying of this artifact in https://github.com/facebook/react/blob/52d542ad6d410008c495084f511247f43387055f/.github/workflows/commit_artifacts.yml#L136-L138 As described in facebook#27664, this artifact doesn't have any effect on the `hash`, which is used for generating React version identifier.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
…es (#27665) Instead of #27664, we can just exclude `unstable_server-external-runtime.js` from having sourcemaps for now. We should consider removing manual copying of this artifact in https://github.com/facebook/react/blob/52d542ad6d410008c495084f511247f43387055f/.github/workflows/commit_artifacts.yml#L136-L138 As described in #27664, this artifact doesn't have any effect on the `hash`, which is used for generating React version identifier. DiffTrain build for commit 78c71bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of #27664, we can just exclude
unstable_server-external-runtime.jsfrom having sourcemaps for now.We should consider removing manual copying of this artifact in
react/.github/workflows/commit_artifacts.yml
Lines 136 to 138 in 52d542a
As described in #27664, this artifact doesn't have any effect on the
hash, which is used for generating React version identifier.