[Static][Fizz] Carry forward bootstrap config to resume if postponing in the shell #27672
+51
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
…r and then during a resume the bootstrap scripts would not be emitted leading to no hydration on the client. This change moves the bootstrap configuration to ResumableState where it can be serialized after postponing if it wasn't flushed as part of the static shell.
gnoff
force-pushed
the
fix-bootstrap-on-resume
branch
from
e6916ed to
269ac62
Compare
sebmarkbage
approved these changes
Nov 8, 2023
sebmarkbage
reviewed
Nov 8, 2023
| @@ -612,9 +618,6 @@ export function resumeRenderState( | |||
| return createRenderState( | |||
| resumableState, | |||
| nonce, | |||
| // These should have already been flushed in the prerender. | |||
| undefined, | |||
| undefined, | |||
There was a problem hiding this comment.
You removed three options. How come only two are removed?
sebmarkbage
reviewed
Nov 8, 2023
| @@ -92,8 +92,6 @@ export function createRenderState( | |||
| undefined, | |||
| undefined, | |||
| undefined, | |||
| undefined, | |||
| undefined, | |||
There was a problem hiding this comment.
Same here. Were we sending one less already?
There was a problem hiding this comment.
Yeah I checked on those, I believe we were sending too many undefineds before. I confirmed the signature has six args and there are six inputs when 2 are removed
github-actions bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
… in the shell (#27672) Previously it was possible to postpone in the shell during a prerender and then during a resume the bootstrap scripts would not be emitted leading to no hydration on the client. This change moves the bootstrap configuration to `ResumableState` where it can be serialized after postponing if it wasn't flushed as part of the static shell. DiffTrain build for [7508dcd](7508dcd)
gnoff
added a commit
to gnoff/next.js
that referenced
this pull request
Nov 8, 2023
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 8, 2023
Updated React from 2983249dd to 7508dcd5c. - facebook/react#27672 - facebook/react#27132 - facebook/react#27646 - facebook/react#26446
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
… in the shell (facebook#27672) Previously it was possible to postpone in the shell during a prerender and then during a resume the bootstrap scripts would not be emitted leading to no hydration on the client. This change moves the bootstrap configuration to `ResumableState` where it can be serialized after postponing if it wasn't flushed as part of the static shell.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
… in the shell (#27672) Previously it was possible to postpone in the shell during a prerender and then during a resume the bootstrap scripts would not be emitted leading to no hydration on the client. This change moves the bootstrap configuration to `ResumableState` where it can be serialized after postponing if it wasn't flushed as part of the static shell. DiffTrain build for commit 7508dcd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was possible to postpone in the shell during a prerender and then during a resume the bootstrap scripts would not be emitted leading to no hydration on the client. This change moves the bootstrap configuration to
ResumableStatewhere it can be serialized after postponing if it wasn't flushed as part of the static shell.