Skip to content

[Flight] Bound server references should be able to be bound again #27695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sebmarkbage merged 1 commit into from
Nov 14, 2023
Merged

[Flight] Bound server references should be able to be bound again #27695

sebmarkbage merged 1 commit into from
Nov 14, 2023

Conversation

@sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Nov 14, 2023

Wasn't consistent. Probably should use a shared helper maybe.

@sebmarkbage sebmarkbage requested a review from gnoff November 14, 2023 02:18
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 14, 2023
@react-sizebot
Copy link

react-sizebot commented Nov 14, 2023 •
edited
Loading

Comparing: 432b9f1...13da8ad

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 175.90 kB 175.90 kB = 54.75 kB 54.75 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.97 kB 177.97 kB = 55.39 kB 55.39 kB
facebook-www/ReactDOM-prod.classic.js = 569.68 kB 569.68 kB = 100.27 kB 100.27 kB
facebook-www/ReactDOM-prod.modern.js = 553.54 kB 553.54 kB = 97.36 kB 97.36 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js +0.27% 25.59 kB 25.66 kB +0.14% 8.80 kB 8.82 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js +0.27% 25.59 kB 25.66 kB +0.14% 8.80 kB 8.82 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.min.js +0.27% 26.32 kB 26.39 kB = 8.96 kB 8.96 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.min.js +0.27% 26.32 kB 26.39 kB = 8.96 kB 8.96 kB
oss-stable-semver/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.production.min.js +0.26% 26.43 kB 26.50 kB = 9.04 kB 9.03 kB
oss-stable/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.production.min.js +0.26% 26.43 kB 26.50 kB = 9.04 kB 9.03 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.min.js +0.26% 26.63 kB 26.70 kB = 9.06 kB 9.05 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.min.js +0.26% 26.63 kB 26.70 kB = 9.06 kB 9.05 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +0.26% 27.07 kB 27.14 kB +0.02% 9.14 kB 9.14 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +0.26% 27.07 kB 27.14 kB +0.02% 9.14 kB 9.14 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +0.26% 27.16 kB 27.23 kB +0.01% 9.24 kB 9.25 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +0.26% 27.16 kB 27.23 kB +0.01% 9.24 kB 9.25 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js +0.26% 27.26 kB 27.33 kB +0.01% 9.21 kB 9.21 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js +0.26% 27.26 kB 27.33 kB +0.01% 9.21 kB 9.21 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.min.js +0.25% 27.63 kB 27.70 kB = 9.40 kB 9.40 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.min.js +0.25% 27.63 kB 27.70 kB = 9.40 kB 9.40 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.min.js +0.25% 28.12 kB 28.19 kB = 9.54 kB 9.54 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.min.js +0.25% 28.12 kB 28.19 kB = 9.54 kB 9.54 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.min.js +0.25% 28.42 kB 28.49 kB = 9.60 kB 9.60 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.min.js +0.25% 28.42 kB 28.49 kB = 9.60 kB 9.60 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.min.js +0.24% 28.63 kB 28.70 kB +0.12% 9.67 kB 9.68 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +0.24% 28.93 kB 29.00 kB = 9.76 kB 9.75 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +0.24% 28.93 kB 29.00 kB = 9.76 kB 9.75 kB
oss-experimental/react-server-dom-turbopack/umd/react-server-dom-turbopack-server.browser.production.min.js +0.24% 29.53 kB 29.60 kB = 9.89 kB 9.88 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.min.js +0.24% 29.41 kB 29.48 kB = 9.80 kB 9.80 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.min.js +0.24% 29.73 kB 29.80 kB = 9.90 kB 9.90 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.min.js +0.23% 30.16 kB 30.23 kB = 10.00 kB 10.00 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-server.browser.production.min.js +0.23% 30.26 kB 30.33 kB = 10.11 kB 10.10 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.min.js +0.23% 30.36 kB 30.43 kB = 10.06 kB 10.06 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.production.min.js +0.23% 30.67 kB 30.74 kB = 10.25 kB 10.25 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.min.js +0.22% 31.16 kB 31.23 kB = 10.41 kB 10.41 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.min.js +0.22% 31.46 kB 31.53 kB = 10.45 kB 10.45 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.min.js +0.22% 31.97 kB 32.04 kB = 10.61 kB 10.61 kB

Generated by 🚫 dangerJS against 13da8ad

@sebmarkbage sebmarkbage merged commit 07cc4a0 into facebook:main Nov 14, 2023
This was referenced Nov 14, 2023
Merged
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Nov 15, 2023
@shuding
Upgrade vendored React (#58489)
036f480 
### React upstream changes

- facebook/react#27694
- facebook/react#27695
- facebook/react#27689
- facebook/react#27687
- facebook/react#27677
- facebook/react#27681
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@sebmarkbage @AndyPengc12
[Flight] Bound server references should be able to be bound again (fa…
02ce2c5 
…cebook#27695)

Wasn't consistent. Probably should use a shared helper maybe.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@sebmarkbage
[Flight] Bound server references should be able to be bound again (#2…
9ab6626 
…7695)

Wasn't consistent. Probably should use a shared helper maybe.

DiffTrain build for commit 07cc4a0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnoff gnoff Awaiting requested review from gnoff

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sebmarkbage @react-sizebot @facebook-github-bot