Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ReactDOM.createRoot in latest v18 from ReactDOM.render #27747

Closed
wants to merge 1 commit into from
Closed

Update to ReactDOM.createRoot in latest v18 from ReactDOM.render #27747

wants to merge 1 commit into from

Conversation

weikhor
Copy link

@weikhor weikhor commented Nov 24, 2023

Summary

To update to syntax with latest version from ReactDOM.render to ReactDOM.createRoot .

How did you test this change?

Before code change
image

After code changes
image

@facebook-github-bot
Copy link

Hi @weikhor!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@react-sizebot
Copy link

Comparing: 6c7b41d...8f4c5f4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 175.90 kB 175.90 kB = 54.75 kB 54.76 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.97 kB 177.97 kB = 55.39 kB 55.39 kB
facebook-www/ReactDOM-prod.classic.js = 569.81 kB 569.81 kB = 100.29 kB 100.29 kB
facebook-www/ReactDOM-prod.modern.js = 553.67 kB 553.67 kB = 97.38 kB 97.38 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 8f4c5f4

@Biki-das
Copy link
Contributor

Biki-das commented Nov 27, 2023

@weikhor
#27722 (comment)

this is not something the project is looking forward, you can close this one

@weikhor weikhor closed this Nov 27, 2023
@weikhor weikhor deleted the react_root_update_syntax branch November 27, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants