New class instantiation and initialization process #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
force-pushed
the
modernclasses
branch
from
914da32 to
548ea09
Compare
sebmarkbage
changed the title
sebmarkbage
added
GH Review: needs-revision
and removed
GH Review: needs-revision
labels
| @@ -123,7 +109,7 @@ var ReactCompositeComponentMixin = assign({}, | |||
| this._rootNodeID = null; | |||
|
|
|||
| this._instance.props = element.props; | |||
| this._instance.state = null; | |||
| // state gets set up during mount | |||
There was a problem hiding this comment.
Is state is already set to null here from the constructor?
There was a problem hiding this comment.
Er… never mind; the constructor calls getInitialState. This comment seems wrong then.
There was a problem hiding this comment.
well it gets reset during mount. this can be simplified later. if it's undefined, it gets set to null.
|
lgtm |
This allows state to be set up in the constructor instead of through getInitialState. getInitialState is now considered part of "classic". Therefore, they move into ReactClass's constructor. As a consequence of this, we no longer have a mapping between the internal representation and the public instance during the mounting process. Because the constructor hasn't returned yet. We used to have a special case for calling setState in getInitialState which was just ignored. This makes that throw and the component is considered unmounted during the construction phase.
sebmarkbage
force-pushed
the
modernclasses
branch
from
548ea09 to
291a92c
Compare
sebmarkbage
added a commit
that referenced
this pull request
Jan 20, 2015
New class instantiation and initialization process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #2806
This allows state to be set up in the constructor instead of through
getInitialState. getInitialState is now considered part of "classic".
Therefore, they move into ReactClass's constructor.
As a consequence of this, we no longer have a mapping between the internal
representation and the public instance during the mounting process.
Because the constructor hasn't returned yet.
We used to have a special case for calling setState in getInitialState
which was just ignored. This makes that throw and the component is
considered unmounted during the construction phase.