-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up experimental flags #28116
Clean up experimental flags #28116
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,6 +34,8 @@ const __EXPERIMENTAL__ = | |
? RELEASE_CHANNEL === 'experimental' | ||
: true; | ||
|
||
const __NEXT_MAJOR__ = __EXPERIMENTAL__; | ||
|
||
// Errors in promises should be fatal. | ||
let loggedErrors = new Set(); | ||
process.on('unhandledRejection', err => { | ||
|
@@ -468,6 +470,7 @@ function getPlugins( | |
? "'production'" | ||
: "'development'", | ||
__EXPERIMENTAL__, | ||
__NEXT_MAJOR__, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of setting this up as a global I was suggesting that it would just be a constant inside ReactFeatureFlags.js so that it doesn't leak. Since it's a temporary state it's annoying to go around update tests and other things that might be flagged on this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok fixed |
||
}, | ||
}), | ||
// The CommonJS plugin *only* exists to pull "art" into "react-art". | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll turn these on in experimental in follow up PRs.